feat(24.04): add polkitd and dependencies #325
Conversation
Meulengracht
changed the title
|
Diff of dependencies: slices/polkitd.yaml@@ -1,7 +1,4 @@
-adduser
-dbus-system-bus
-default-dbus-system-bus
-default-logind
+dbus-broker
libc6
libduktape207
libexpat1
@@ -10,6 +7,6 @@
libpolkit-agent-1-0
libpolkit-gobject-1-0
libsystemd0
-logind
-systemd-sysusers
+login
+opensysusers
xml-coreslices/sgml-base.yaml@@ -1 +0,0 @@
-dpkgslices/xml-core.yaml@@ -1,2 +1 @@
-sed
sgml-base |
Meulengracht
force-pushed
the
slices/polkitd
branch
from
82afcf4
to
ae76352
Compare
Meulengracht
force-pushed
the
slices/polkitd
branch
from
ec4d62c
to
d73a648
Compare
There was a problem hiding this comment.
Dep diff change: you seem to be using alternative dependencies (e.g. login instead of logind), dropping a few (e.g. sed) and adding some new ones as well. Is this all intentional? If so, can you please add comments where they are being listed, explaining the rationale?
There are also some tests missing. We should aim to test at least every single executable being proposed.
| @@ -0,0 +1,38 @@ | |||
| package: dbus-broker | |||
There was a problem hiding this comment.
can you also test these slices pls?
| @@ -4,6 +4,14 @@ essential: | |||
| - libglib2.0-0t64_copyright | |||
|
|
|||
| slices: | |||
| bins: | |||
There was a problem hiding this comment.
can you test this pls?
| @@ -0,0 +1,31 @@ | |||
| package: login | |||
There was a problem hiding this comment.
can you please test this?
| /bin/systemd-sysusers: | ||
| /etc/init.d/opensysusers: | ||
| /usr/bin/opensysusers-sysusers: |
There was a problem hiding this comment.
same here, can you pls test them?
| /usr/lib/policykit-1/polkit-agent-helper-1: | ||
| /usr/lib/polkit-1/polkit-agent-helper-1: |
There was a problem hiding this comment.
are these helpers needed? Or could they belong to an additional slice?
| /usr/sbin/halt: | ||
| /usr/sbin/init: | ||
| /usr/sbin/poweroff: | ||
| /usr/sbin/reboot: | ||
| /usr/sbin/runlevel: | ||
| /usr/sbin/shutdown: | ||
| /usr/sbin/telinit: |
There was a problem hiding this comment.
can you test these pls?
Proposed changes
Polkitd and it's dependencies are required for Ubuntu Core 24. Add the slices, and mutation scripts required to imitate what happens by postinst or perl scripts that are carried by included packages.
Two mutation scripts are added:
xml-corewhich handles updating the xml catalogsgml-basewhich handles updating the sgml catalogRelated issues/PRs
Requires #293 and #274 to land
Forward porting
Once this is approved I'll forward port this to 24.10
Checklist