Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcase to check power-mode before and after suspend #824

Closed
wants to merge 1 commit into from

Conversation

binli
Copy link
Contributor

@binli binli commented Nov 10, 2023

Description

With Platform Profile (low-power, balanced, performance) support being added to the kernel and GNOME we'd like this to be tested to confirm it is working during HW enablement/certification.
It is expected functionality on these platforms and we need to highlight any issues with it not working to the FW team so it can be fixed before preload signoff.

Resolved issues

Original bug: https://bugs.launchpad.net/sutton/+bug/2036435

Documentation

This testcase could help verify power mode can stay in the chosen setting after suspend.

Tests

Outcome: job passed
==============[ Running job 6 / 7. Estimated time left: 0:00:02 ]===============
--------[ Dumps power_mode info to a file for comparison after suspend ]--------
ID: com.canonical.certification::suspend/power_mode_before_suspend
Category: com.canonical.plainbox::suspend
... 8< -------------------------------------------------------------------------
------------------------------------------------------------------------- >8 ---
Outcome: job passed
==============[ Running job 7 / 7. Estimated time left: 0:00:01 ]===============
----------------------[ suspend/power_mode_after_suspend ]----------------------
ID: com.canonical.certification::suspend/power_mode_after_suspend
Category: com.canonical.plainbox::suspend
... 8< -------------------------------------------------------------------------
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2023-11-10T11.52.36
==================================[ Results ]===================================
 ☑ : Create resource info for supported sleep states
 ☑ : Creates resource info for RTC
 ☑ : Automated test of suspend function
 ☑ : Collect information about kernel modules
 ☑ : Collect information about installed software packages
 ☑ : Dumps power_mode info to a file for comparison after suspend
 ☑ : suspend/power_mode_after_suspend

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #824 (46d6d48) into main (3ad8c49) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   35.25%   35.25%           
=======================================
  Files         302      302           
  Lines       34173    34173           
  Branches     5907     5907           
=======================================
  Hits        12048    12048           
  Misses      21559    21559           
  Partials      566      566           
Flag Coverage Δ
provider-base 4.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the lack of feedback on this one...

I made a few comments and suggestions (you can accept them directly in GitHub and it will create a commit for you with the change).

The Python script will also require unit tests.

providers/base/units/suspend/suspend.pxu Show resolved Hide resolved
providers/resource/bin/power_mode_resource.py Show resolved Hide resolved
providers/resource/bin/power_mode_resource.py Show resolved Hide resolved
@kissiel
Copy link
Contributor

kissiel commented Jan 12, 2024

After talking with Binli we learned that he's busy ATM, so his PRs are on hold, and because they need work done on them I'm switching the state to "Draft"

@kissiel kissiel marked this pull request as draft January 12, 2024 14:14
@kissiel kissiel closed this Mar 18, 2024
@binli
Copy link
Contributor Author

binli commented Apr 3, 2024

I open another pull request, please help review it when you guys are free, #1145 , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants