Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove autoheal functionality from rhsmcertd #3455

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jvlcek
Copy link
Contributor

@jvlcek jvlcek commented Sep 12, 2024

Card ID: CCT-723

Removed autoheal sub-command from rhsmcertd because autoheal is useless in pure SCA mode..

@jvlcek jvlcek marked this pull request as draft September 12, 2024 20:41
@jvlcek
Copy link
Contributor Author

jvlcek commented Sep 12, 2024

@jirihnidek Here is my draft PR. Please take a look.

I have three questions:

  1. How do I test these changes beyond running the pytests?
  2. It looks to me like auto_attach_initial_delay , auto_attach_offset, and NEXT_AUTO_ATTACH_UPDATE_FILE can also be removed from src/daemons/rhsmcertd.c. Do you know if that is correct?
  3. What should I do about the deprication message from man/rhsmcertd.8 ?
    https://github.com/candlepin/subscription-manager/blob/main/man/rhsmcertd.8#L103-L114

Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It generally seems good, there are few things to fix. Also drop an extra import, see the flake8 failure (it appears also as inline notes in the "files changed" view in github).

It looks to me like auto_attach_initial_delay , auto_attach_offset, and NEXT_AUTO_ATTACH_UPDATE_FILE can also be removed from src/daemons/rhsmcertd.c. Do you know if that is correct?

Yes, it looks so.

What should I do about the deprication message from man/rhsmcertd.8 ?

Edit it to mention only one parameter, according to the changes done here.

That feature looks something to remove as well, and I'd do that in a separate commit/PR.

INSTALL.md Outdated Show resolved Hide resolved
src/daemons/rhsmcertd.c Outdated Show resolved Hide resolved
src/daemons/rhsmcertd.c Outdated Show resolved Hide resolved
src/daemons/rhsmcertd.c Show resolved Hide resolved
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have same comments as Pino has.

INSTALL.md Outdated Show resolved Hide resolved
src/daemons/rhsmcertd.c Outdated Show resolved Hide resolved
test/test_certmgr.py Outdated Show resolved Hide resolved
@jvlcek
Copy link
Contributor Author

jvlcek commented Sep 13, 2024

Thank you @ptoscano and @jirihnidek for all of the help and patience.

I believe I have addressed all of the issues you've identified so far.

I will now squash all of the commits I created while resolving yourreview feedback.

@jvlcek jvlcek marked this pull request as ready for review September 13, 2024 18:42
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, this seems better now; I'll give it a try later on

man/rhsmcertd.8 Outdated Show resolved Hide resolved
src/daemons/rhsmcertd.c Outdated Show resolved Hide resolved
src/daemons/rhsmcertd.c Outdated Show resolved Hide resolved
@jvlcek
Copy link
Contributor Author

jvlcek commented Sep 23, 2024

Thank you for the feedback @ptoscano
I will squash my comments are rebase.

Card ID: CCT-723

Removed autoheal sub-command from rhsmcertd because
autoheal is useless in pure SCA mode..
@ptoscano ptoscano merged commit c124784 into candlepin:main Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants