Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement commit on match #57

Merged
merged 29 commits into from
Sep 20, 2024
Merged

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Sep 18, 2024

an example of a successful modification made by the lint : 8e7613c

related to https://github.com/camunda/team-infrastructure-experience/issues/344

I also implemented yamlfmt in the PR + auto update of the GHA

A re-usable workflow has been added to the PR, an example of it being called: camunda/camunda-tf-eks-module#116 (this PR is dependant of the this one to be merged in order to have the version pinned on main)

@leiicamundi leiicamundi changed the title feat: implement commit on match draft: feat: implement commit on match Sep 18, 2024
@leiicamundi leiicamundi changed the title draft: feat: implement commit on match feat: implement commit on match Sep 18, 2024
@leiicamundi leiicamundi marked this pull request as draft September 18, 2024 14:26
@leiicamundi leiicamundi marked this pull request as ready for review September 19, 2024 08:48
@leiicamundi leiicamundi force-pushed the feature/auto-update-renovate-doc branch from 33e694f to 740ad1e Compare September 19, 2024 10:22
@leiicamundi leiicamundi force-pushed the feature/auto-update-renovate-doc branch 2 times, most recently from 8ff9a17 to defa60d Compare September 19, 2024 11:16
@leiicamundi leiicamundi added the enhancement New feature or request label Sep 19, 2024
@leiicamundi leiicamundi self-assigned this Sep 19, 2024
@leiicamundi leiicamundi enabled auto-merge (squash) September 19, 2024 11:42
@leiicamundi leiicamundi marked this pull request as draft September 19, 2024 12:30
auto-merge was automatically disabled September 19, 2024 12:30

Pull request was converted to draft

@leiicamundi leiicamundi marked this pull request as ready for review September 19, 2024 12:40
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing I'd probably change as you already have a reuseable workflow with the same content

@leiicamundi leiicamundi force-pushed the feature/auto-update-renovate-doc branch from 075e6cc to f8bbaa7 Compare September 20, 2024 10:00
@leiicamundi
Copy link
Contributor Author

Thanks @Langleu

To address the verify requirement, we need to use the GitHub API since bots are not permitted to have GPG keys. I updated the GitHub Action to handle the commit and squashed the commits. Now, the infraex bot makes verified commits: 851daff.

@leiicamundi leiicamundi merged commit 029c517 into main Sep 20, 2024
6 checks passed
@leiicamundi leiicamundi deleted the feature/auto-update-renovate-doc branch September 20, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants