Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed workaround for connectors in OpenShift routes #4249

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

hamza-m-masood
Copy link
Contributor

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@hamza-m-masood hamza-m-masood self-assigned this Sep 3, 2024
@hamza-m-masood hamza-m-masood changed the title removed workaround for connectors in OpenShift routes fix: removed workaround for connectors in OpenShift routes Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@hamza-m-masood hamza-m-masood added target:8.6 Issues included in the 8.6 release target:8.5 labels Sep 3, 2024
@hamza-m-masood hamza-m-masood marked this pull request as ready for review September 4, 2024 00:02
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question on if steps 4 and 5 can be condensed. Otherwise happy for this to be merged once it's good to go from distribution.

@@ -326,37 +326,6 @@ tasklist:
The actual configuration properties can be reviewed [in the Tasklist configuration documentation](/self-managed/tasklist-deployment/tasklist-configuration.md#zeebe-broker-connection).

5. For Connectors:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged into step 4 now that Connectors don't have a separate set of requirements/steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conceptualshark Connectors have a different set of env vars. I think it is still a good idea to have them separate.

@conceptualshark
Copy link
Contributor

@hamza-m-masood Is this needed for the alpha release? Does it still need distribution review?

aabouzaid
aabouzaid previously approved these changes Sep 12, 2024
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@hamza-m-masood
Copy link
Contributor Author

@conceptualshark It is reviewed from distribution now. Feel free to merge.

@hamza-m-masood
Copy link
Contributor Author

@conceptualshark can this be merged?

@conceptualshark conceptualshark dismissed stale reviews from aabouzaid and themself via 407b1ed September 19, 2024 13:27
@conceptualshark conceptualshark merged commit e2a794e into main Sep 19, 2024
7 checks passed
@conceptualshark conceptualshark deleted the openshift-connectors-routes branch September 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target:8.5 target:8.6 Issues included in the 8.6 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants