fix: nested text styling not inheriting from parent #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rayan1810, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
scarletcs
reviewed
May 2, 2024
rayan1810
changed the title
|
Ready for Review ✅ |
rayan1810
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #4351 by adding a React Context with Text Component and checks + reads the parent Text's context to get it's style and merges it with the current Text's style, just like how React Native behaves.
Related issue
#4351
Test plan
Testing is pending, the PR is still a Work in progress!