Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cost expression names & split out expressions #685

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brynpickering
Copy link
Member

Fixes #645

The only thing I have chosen to not implement from #645 is cost_investment -> cost_investment_total. I'm not sure that _total adds anything...

Summary of changes in this pull request

  • the total capital cost is now cost_investment
  • the annualised capital cost is now cost_investment_annualised
  • fixed operation costs are now cost_operation_fixed
  • variable operation costs are now cost_operation_variable
  • total cost is the sum of cost_investment_annualised, cost_operation_fixed, and cost_operation_variable.

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (62dcd34) to head (19a63f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          26       26           
  Lines        3981     3982    +1     
  Branches      837      768   -69     
=======================================
+ Hits         3821     3822    +1     
  Misses         70       70           
  Partials       90       90           
Files with missing lines Coverage Δ
src/calliope/backend/helper_functions.py 96.86% <100.00%> (+0.01%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential misinterpretation of (internal) cost calculation related to OM cost term
1 participant