Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write status first then hijack #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

write status first then hijack #126

wants to merge 1 commit into from

Conversation

WeidiDeng
Copy link
Member

1. What does this change do, exactly?

Write Status first then hijack the response writer. This allows the access log to correctly record response status. Also removed some of the redundant error checking.

2. Please link to the relevant issues.

3. Which documentation changes (if any) need to be made because of this PR?

4. Checklist

  • I have written tests and verified that they fail without my change
  • I made pull request as minimal and simple as possible. If change is not small or additional dependencies are required, I opened an issue to propose and discuss the design first
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@mholt
Copy link
Member

mholt commented May 2, 2024

Thanks Weidi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants