Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntrnl 423 integrate notify project into GitHub request app #76

Merged
merged 8 commits into from
May 16, 2024
Merged

Ntrnl 423 integrate notify project into GitHub request app #76

merged 8 commits into from
May 16, 2024

Conversation

DanielMurray97
Copy link
Contributor

@DanielMurray97 DanielMurray97 commented May 10, 2024 •
edited
Loading

JIRA link

Resolves NTRNL-423

Description

  • Integrated Notify - creating a confirmation email function for when a request has been submitted.
  • Create Notify feature flag
  • Updated env.example with Notify env variables

Work checklist

  • Tests added where applicable
  • No vulnerability added

Screenshot from 2024-05-15 16-36-42

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 861/861
🟢 Branches
97.3% (+0.15% 🔼)
 36/37
🟢 Functions 100% 69/69
🟢 Lines 100% 797/797
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢 service/notify.ts 100% 100% 100% 100%
🟢 notifications-node-client.d.ts 100% 100% 100% 100%

Test suite run success

182 tests passing in 51 suites.

Report generated by 🧪jest coverage report action from 74d3c3e

@DanielMurray97 DanielMurray97 force-pushed the NTRNL-423-integrate-notify-project-into-github-request-app branch from ce558ce to 3aece6d Compare May 14, 2024 14:08
@DanielMurray97 DanielMurray97 force-pushed the NTRNL-423-integrate-notify-project-into-github-request-app branch 2 times, most recently from 9be11d8 to 42ae87f Compare May 15, 2024 15:25
@DanielMurray97 DanielMurray97 marked this pull request as ready for review May 15, 2024 15:31
Mouhajer-CO
Mouhajer-CO approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @DanielMurray97 🔥

@DanielMurray97 DanielMurray97 merged commit e134201 into main May 16, 2024
6 checks passed
@DanielMurray97 DanielMurray97 deleted the NTRNL-423-integrate-notify-project-into-github-request-app branch May 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouhajer-CO Mouhajer-CO Mouhajer-CO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMurray97 @Mouhajer-CO