-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ntrnl 411 make check your answers page consistency changes #67
Merged
harley-harris
merged 7 commits into
main
from
NTRNL-411-make-check-your-answers-page-consistency-changes
Apr 17, 2024
Merged
Ntrnl 411 make check your answers page consistency changes #67
harley-harris
merged 7 commits into
main
from
NTRNL-411-make-check-your-answers-page-consistency-changes
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Test suite run success174 tests passing in 47 suites. Report generated by 🧪jest coverage report action from 834620e |
harley-harris
force-pushed
the
NTRNL-411-make-check-your-answers-page-consistency-changes
branch
from
April 17, 2024 13:39
4a2beae
to
22c2e11
Compare
…end style more closely
… in check-your-answers summary
…stead of underscore
harley-harris
force-pushed
the
NTRNL-411-make-check-your-answers-page-consistency-changes
branch
from
April 17, 2024 13:42
22c2e11
to
834620e
Compare
DanielMurray97
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, LGTM 🔥
harley-harris
deleted the
NTRNL-411-make-check-your-answers-page-consistency-changes
branch
April 17, 2024 14:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
NTRNL-411
Description
Variety of consistency changes related to
/check-your-answers
page following application deep dive session:/check-your-answers
to more appropriatecheck-your-requests
check-your-requests
page to be consistent with ordering on/home
pageWork checklist
Before
After