Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 411 make check your answers page consistency changes #67

Merged

Conversation

harley-harris
Copy link
Contributor

@harley-harris harley-harris commented Apr 16, 2024

JIRA link

NTRNL-411

Description

Variety of consistency changes related to /check-your-answers page following application deep dive session:

  • Rename /check-your-answers to more appropriate check-your-requests
  • Reorder the requests on check-your-requests page to be consistent with ordering on /home page
  • Remove "Added" from request titles and resize title to be more inline with gov-uk frontend examples
  • Make repository visibility, context and contract_type values more human-readable

Work checklist

  • Tests added where applicable
  • No vulnerability added

Before

Screenshot 2024-04-16 at 15 34 13

After

Screenshot 2024-04-16 at 15 38 19

Copy link

github-actions bot commented Apr 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 812/812
🟢 Branches 96.88% 31/32
🟢 Functions 100% 64/64
🟢 Lines 100% 754/754
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / check-your-requests.controller.ts
100% 100% 100% 100%
🟢
... / check-your-requests.ts
100% 100% 100% 100%

Test suite run success

174 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 834620e

@harley-harris harley-harris force-pushed the NTRNL-411-make-check-your-answers-page-consistency-changes branch from 4a2beae to 22c2e11 Compare April 17, 2024 13:39
@harley-harris harley-harris force-pushed the NTRNL-411-make-check-your-answers-page-consistency-changes branch from 22c2e11 to 834620e Compare April 17, 2024 13:42
Copy link
Contributor

@DanielMurray97 DanielMurray97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, LGTM 🔥

@harley-harris harley-harris merged commit 5de62a3 into main Apr 17, 2024
6 checks passed
@harley-harris harley-harris deleted the NTRNL-411-make-check-your-answers-page-consistency-changes branch April 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants