Ntrnl 377 add environment variables to substitute reference to cabinet office or co words #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success174 tests passing in 47 suites. Report generated by 🧪jest coverage report action from d9fbd01 |
|
On the
Organisation doesn't make sense in this context as we are civil servants are employed by departments. |
harley-harris
approved these changes
Apr 11, 2024
src/config/index.ts
Outdated
| @@ -1,7 +1,8 @@ | |||
| import { getEnvironmentValue } from '../utils/getEnvironmentValue'; | |||
|
|
|||
| export const SERVICE_NAME = 'GitHub Requests'; | |||
| export const ORG_NAME = 'The Cabinet Office'; | |||
| export const DEPARTMENT_NAME = 'Cabinet Office'; | |||
There was a problem hiding this comment.
These would probably be better in .env.example so they are easier for users to change
src/config/index.ts
Outdated
| @@ -1,7 +1,8 @@ | |||
| import { getEnvironmentValue } from '../utils/getEnvironmentValue'; | |||
|
|
|||
| export const SERVICE_NAME = 'GitHub Requests'; | |||
| export const ORG_NAME = 'The Cabinet Office'; | |||
| export const DEPARTMENT_NAME = 'Cabinet Office'; | |||
| export const GITHUB_ORG_NAME = 'Cabinet Office'; | |||
There was a problem hiding this comment.
should be cabinetoffice
DanielMurray97
force-pushed
the
NTRNL-377-add-environment-variables-to-substitute-reference-to-cabinet-office-or-co-words
branch
from
d5c8005
to
d9fbd01
Compare
| @@ -10,6 +10,8 @@ GITHUB_OWNER="test" | |||
| GITHUB_REPO_ISSUE_ASSIGNEE="test" | |||
| GITHUB_REPO_ISSUE_LABEL="test" | |||
| GITHUB_TERRAFORM_REPO="test" | |||
| DEPARTMENT_NAME ="Cabinet Office" | |||
There was a problem hiding this comment.
env vars are alphabetical
DanielMurray97
deleted the
NTRNL-377-add-environment-variables-to-substitute-reference-to-cabinet-office-or-co-words
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
NTRNL-377
Description
Work checklist