Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 392 add contact us page #60

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

harley-harris
Copy link
Contributor

@harley-harris harley-harris commented Apr 2, 2024

JIRA link

NTRNL-392

Description

  • Add Contact Us static page
  • Some minor code fixes:
    • Add authentication mock to cookies page integration test
    • Correct the filename for the /additional-requests route

Work checklist

  • Tests added where applicable
  • No vulnerability added
Screenshot 2024-04-02 at 11 37 57

@harley-harris harley-harris requested a review from a team April 2, 2024 10:40
@harley-harris harley-harris self-assigned this Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 793/793
🟢 Branches 96.88% 31/32
🟢 Functions 100% 63/63
🟢 Lines 100% 736/736
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / additional-requests.ts
100% 100% 100% 100%
🟢
... / contact-us.ts
100% 100% 100% 100%
🟢
... / contact-us.controller.ts
100% 100% 100% 100%

Test suite run success

172 tests passing in 45 suites.

Report generated by 🧪jest coverage report action from 91299eb

Copy link
Contributor

@DanielMurray97 DanielMurray97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harley-harris harley-harris merged commit cff12a9 into main Apr 2, 2024
4 checks passed
@harley-harris harley-harris deleted the NTRNL-392-add-contact-us-page branch April 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants