Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 400 add missing env variables to files and format consistently #57

Conversation

harley-harris
Copy link
Contributor

@harley-harris harley-harris commented Mar 25, 2024

JIRA link

NTRNL-400

Description

  • Add missing env variables to files and format consistently
  • Add explanation that static assets will not load if CDN_HOST env variable is not provided
  • Add missing step to explain to build project in README.md

Work checklist

  • Tests added where applicable
  • No vulnerability added

…s from docker-compose (FEATURE_FLAG_ENABLE_AUTH, GITHUB_KEY, SESSION_APP_KEY, SESSION_ID_NAME)
…rmat to be consistent with docker-compose.yml and README.md files
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 691/691
🟢 Branches 96.88% 31/32
🟢 Functions 100% 56/56
🟢 Lines 100% 641/641

Test suite run success

151 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from 1a8f91a

Copy link
Contributor

@DanielMurray97 DanielMurray97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harley-harris harley-harris merged commit 3e60235 into main Mar 26, 2024
4 checks passed
@harley-harris harley-harris deleted the NTRNL-400-add-missing-env-variables-to-files-and-format-consistently branch March 26, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants