Ntrnl 361 create width container commmon component #54
Conversation
Coverage report
Test suite run success151 tests passing in 39 suites. Report generated by 🧪jest coverage report action from 3647810 |
| @@ -4,117 +4,113 @@ | |||
| {% include "include/back-link.html" %} | |||
| {% endblock %} | |||
|
|
|||
| {% block content %} | |||
There was a problem hiding this comment.
Why are we replacing whole chunks rather Inplace editing with what is required to be updated?
There was a problem hiding this comment.
refactoring shall be better as it is done in add-team-member.html
There was a problem hiding this comment.
Hi Nayyab,
The changes involved with this PR involve de-denting all the pages html code by to accommodate the implementation of the common width container.
I believe that git has detected the add-member changes as inline because it's a small file with no embedded nunjucks code (it mostly uses common components). Most of the other pages are much larger so I think it's detecting them as chunk based changes.
harley-harris
deleted the
NTRNL-361-create-width-container-commmon-component
branch
JIRA link
NTRNL-361
Description
Create width container common component
Work checklist