Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 295 add validation mw #18

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

Mouhajer-CO
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO commented Feb 5, 2024

JIRA link

Resolves NTRNL-295

Description

Add validation Middleware

Screenshot 2024-02-04 at 12 14 56

Work checklist

  • Tests added where applicable
  • No vulnerability added

Copy link

github-actions bot commented Feb 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 304/304
🟢 Branches
96.77% (+0.35% 🔼)
30/31
🟢 Functions 100% 29/29
🟢 Lines 100% 278/278
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / validation.middleware.ts
100% 100% 100% 100%
🟢
... / remove-member.validation.ts
100% 100% 100% 100%
🟢
... / error.messages.ts
100% 100% 100% 100%

Test suite run success

61 tests passing in 29 suites.

Report generated by 🧪jest coverage report action from 0ee4861

@Mouhajer-CO Mouhajer-CO requested a review from a team February 5, 2024 10:09
@Mouhajer-CO Mouhajer-CO self-assigned this Feb 5, 2024
@Mouhajer-CO Mouhajer-CO requested a review from a team February 6, 2024 08:16
Copy link
Contributor

@DanielMurray97 DanielMurray97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, LGTM

@Mouhajer-CO Mouhajer-CO merged commit 420a5a0 into main Feb 7, 2024
3 checks passed
@Mouhajer-CO Mouhajer-CO deleted the NTRNL-295-add-validation-mw branch February 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants