Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 524 update endpoints for the GitHub add team page to match the new structure #105

Conversation

harley-harris
Copy link
Contributor

@harley-harris harley-harris commented Aug 13, 2024

JIRA link

NTRNL-528

Description

Refactor /add-team endpoint to /github/<action>/team structure

Work checklist

  • Tests added where applicable
  • No vulnerability added

@harley-harris harley-harris requested a review from a team August 13, 2024 12:32
@harley-harris harley-harris self-assigned this Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 897/897
🟢 Branches 97.44% 38/39
🟢 Functions 100% 71/71
🟢 Lines 100% 831/831
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / team.controller.ts
100% 100% 100% 100%
🟢
... / team.ts
100% 100% 100% 100%
🟢
... / team.validation.ts
100% 100% 100% 100%

Test suite run success

186 tests passing in 52 suites.

Report generated by 🧪jest coverage report action from 0a1afe8

Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harley-harris 👍, approved, very small change on the documentation file on line 158 add_team should be teams but the entire object will change soon

@harley-harris harley-harris merged commit 336dc90 into main Aug 19, 2024
6 checks passed
@harley-harris harley-harris deleted the NTRNL-524-update-endpoints-for-the-github-add-team-page-to-match-the-new-structure branch August 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants