Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 530 update endpoints for the GitHub home page to match the new structure #104

Conversation

DanielMurray97
Copy link
Contributor

@DanielMurray97 DanielMurray97 commented Aug 12, 2024

JIRA link

NTRNL-530

Description

  • Refactor /home endpoint to /github/home structure

Work checklist

  • Tests added where applicable
  • No vulnerability added

Copy link

github-actions bot commented Aug 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 897/897
🟢 Branches 97.44% 38/39
🟢 Functions 100% 71/71
🟢 Lines 100% 831/831
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / github-home.ts
100% 100% 100% 100%
🟢
... / github-home.controller.ts
100% 100% 100% 100%

Test suite run success

186 tests passing in 52 suites.

Report generated by 🧪jest coverage report action from 5cb0c56

@DanielMurray97 DanielMurray97 marked this pull request as ready for review August 12, 2024 08:40
@DanielMurray97 DanielMurray97 requested review from a team and removed request for a team August 12, 2024 08:44
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielMurray97, I have added a simple comment related to the router name and a few notes for future work and improvement.

src/config/index.ts Show resolved Hide resolved
src/routes/github/github-home.ts Outdated Show resolved Hide resolved
src/views/include/back-link.html Show resolved Hide resolved
src/config/index.ts Show resolved Hide resolved
@DanielMurray97 DanielMurray97 merged commit dc82bbf into main Aug 16, 2024
6 checks passed
@DanielMurray97 DanielMurray97 deleted the NTRNL-530-update-endpoints-for-the-github-home-page-to-match-the-new-structure branch August 16, 2024 08:48
@DanielMurray97 DanielMurray97 self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants