Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 546 add static file configuration to use the govuk npm directory #102

Conversation

Mouhajer-CO
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO commented Aug 6, 2024

JIRA link

Resolves NTRNL-546, NTRNL-544 and NTRNL-521

Description

  • Add static file configuration to use the govuk npm directory
  • Fix radio buttons
  • Fix govuk-crest
  • Moved assets folder to CDN (PR in progress).

Work checklist

  • Tests Updated
  • No vulnerability added

Copy link

github-actions bot commented Aug 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 896/896
🟢 Branches 97.44% 38/39
🟢 Functions 100% 71/71
🟢 Lines 100% 830/830

Test suite run success

186 tests passing in 52 suites.

Report generated by 🧪jest coverage report action from 6c522e0

@Mouhajer-CO
Copy link
Contributor Author

Mouhajer-CO commented Aug 6, 2024

Related to: #102, #94 and #88

@Mouhajer-CO Mouhajer-CO requested a review from a team August 6, 2024 13:53
@Mouhajer-CO Mouhajer-CO self-assigned this Aug 6, 2024
Copy link
Contributor

@DanielMurray97 DanielMurray97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, good work, LGTM 🔥

@Mouhajer-CO Mouhajer-CO merged commit 3847f96 into main Aug 7, 2024
6 checks passed
@Mouhajer-CO Mouhajer-CO deleted the NTRNL-546-add-static-file-configuration-to-use-the-govuk-npm-directory branch August 7, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants