Skip to content

Commit

Permalink
assess pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielMurray97 committed Mar 26, 2024
1 parent c0806ab commit 5b016d9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 39 deletions.
48 changes: 10 additions & 38 deletions src/views/add-collaborator.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,56 +5,28 @@
{% endblock %}

{% block pageContent %}
<h1 class="govuk-heading-l">Add a New Collaborator to a Repository</h1>
<h1 class="govuk-heading-l">Add a new collaborator to a repository</h1>

<p class="govuk-body">
When you want to grant more granular access to a repository, you can add an external collaborator directly to the repository.
When a user requires access to one or more repositories but they are not apart of the orginisation, they should be added as an outside collaborator.
</p>

{% include "include/error-list.html" %}

<form method="post" novalidate>


{{ govukInput({
errorMessage: errors.first_name if errors,
label: {
text: "First Name",
classes: "govuk-label--m"
},
classes: "govuk-input--width-20",
id: "first_name",
name: "first_name",
value: first_name
}) }}
{% set firstNameText = "First name" %}
{% include "include/inputs/first-name.html" %}

{{ govukInput({
errorMessage: errors.last_name if errors,
label: {
text: "Last Name",
classes: "govuk-label--m"
},
classes: "govuk-input--width-20",
id: "last_name",
name: "last_name",
value: last_name
}) }}
{% set lastNameText = "Last name" %}
{% include "include/inputs/last-name.html" %}

{% set githubHandleText = "GitHub Handle" %}
{% set githubHandleText = "GitHub handle" %}
{% include "include/inputs/github-handle.html" %}

{{ govukInput({
errorMessage: errors.email_address if errors,
label: {
text: "Email Address",
classes: "govuk-label--m"
},
classes: "govuk-input--width-20",
id: "email_address",
name: "email_address",
value: email_address,
type: "email",
spellcheck: false
}) }}
{% set emailAddressText = "Email address" %}
{% include "include/inputs/email-address.html" %}

{% include "include/inputs/repo-name.html" %}

Expand Down
2 changes: 1 addition & 1 deletion test/mock/text.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const MOCK_BY_ID_TEAM_MEMBER_RESPONSE = 'Team name: team1, GitHub handle(

// add-collaborator response mocks

export const MOCK_GET_ADD_COLLABORATOR_RESPONSE = 'Add a New Collaborator to a Repository';
export const MOCK_GET_ADD_COLLABORATOR_RESPONSE = 'Add a new collaborator to a repository';
export const MOCK_POST_ADD_COLLABORATOR_RESPONSE = 'First name: example, Last name: example, GitHub handle: example, email: [email protected], Repository Name: repo1';
export const MOCK_BY_ID_ADD_COLLABORATOR_RESPONSE = 'GitHub handle: example, Collaborator ID: ';

Expand Down

0 comments on commit 5b016d9

Please sign in to comment.