Skip to content

Commit

Permalink
add README.md corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
harley-harris committed Jan 17, 2024
1 parent a72e925 commit 54542e5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ BASE_URL="http://localhost:3000"
CDN_HOST="d6nh3dxv55e16.cloudfront.net"
NODE_SSL_ENABLED="false"

LOG_LEVEL = info
HUMAN = true
LOG_LEVEL=info
HUMAN=true
15 changes: 9 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

The GitHub request application is a tool designed to streamline and automate the process of managing and tracking request for GitHub. This includes the adding, removal or editing of members.

Each page or user interface, defined by an endpoint, is devided into three components (MVC) and as a best practice the names for the model, view and controller have, when possible, the same start name of the endpoints (es. for the `/info` page we have the: `info.controller.ts` and `info.html` files if model present we will have had `info.model.ts`)
Each page or user interface, defined by an endpoint, is devided into three components (MVC) and as a best practice the names for the model, view and controller have, when possible, the same start name of the endpoints (e.g. for the `/info` page we have the: `info.controller.ts` and `info.html` files if models are present we would have `info.model.ts`)

### The View

Expand All @@ -22,7 +22,7 @@ Directory Path | Description
--- | ---
`./.github` | Github folder, includes `PULL_REQUEST_TEMPLATE.md` on how to make a pull request to the project and `dependabot.yml` configuration options for dependency updates.
`./.husky` | Add pre check script, includes `pre-commit` and `pre-push` checks
`./src` | Contains all typescripts code
`./src` | Contains all Typescript code
`./src/app.ts` | Application entry point
`./src/bin/www.ts` | Server configuration
`./src/config/index.ts` | Contains all the application's configurations
Expand All @@ -31,7 +31,7 @@ Directory Path | Description
`./src/model` | OE Session and View Data Model
`./src/routes` | Paths and routes controller (Only GET and POST enabled)
`./src/service` | Interface to the API through SDK
`./src/utils` | Facade for CH services (logging and session) and other application utils (navigation, application data ...)
`./src/utils` | Facade for CO services (e.g. logging) and other application utils (navigation, application data ...)
`./src/validation` | Sets of express validator middlewares for each page
`./test` | Jest Test files (`*.spec.ts`, `setup.ts`, and `*.mocks.ts`)
`./view` | Contains all the html nunjucks structure files
Expand All @@ -44,8 +44,11 @@ We use ESlint as both a formatter and code quality assurance. Eslint can also be

1. Install the [ESlint VScode extenstion](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint).
2. Open your user settings (JSON) inside VScode and add the following:
```
"editor.formatOnSave": true,
"editor.codeActionsOnSave": { "source.fixAll.eslint": true }
```

3. Reload VScode.

## Running local development environment with Docker
Expand All @@ -64,14 +67,14 @@ Follow the steps in [Launching-the-web-app](#Launching-the-web-app), and ensure

### Building the Docker Image

1. Create a copy of the .env.example file and name it .env:
1. Create a copy of the ``.env.example`` file and name it `.env`:

Then to run:
Then run:

make docker-build

make docker-up

This will then download the necessary dependencies, build the Docker image, and start the application.
You will be able to access it on [Localhost:3000](localhost:3000).
You will be able to access it on [localhost:3000](localhost:3000).

0 comments on commit 54542e5

Please sign in to comment.