Skip to content

Commit

Permalink
Final unit tests for LoginControllerV2
Browse files Browse the repository at this point in the history
  • Loading branch information
@DomWestAnd
DomWestAnd committed Jul 7, 2023
1 parent bbc64d5 commit e4aa3f1
Show file tree
Hide file tree
Showing 2 changed files with 103 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/main/java/gov/cabinetofice/gapuserservice/web/LoginControllerV2.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public RedirectView redirectAfterLogin(final @CookieValue(name = REDIRECT_URL_CO
return new RedirectView("/should-migrate-data");
} else {
// TODO GAP-1932: Migrate cola user data to this admin
oneLoginService.addSubToUser(user.getSub(), user.getEmail());
oneLoginService.addSubToUser(userInfo.getSub(), user.getEmail());
return getRedirectView(user, redirectUrl);
}
}
Expand Down
111 changes: 102 additions & 9 deletions src/test/java/gov/cabinetofice/gapuserservice/web/LoginControllerV2Test.java
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
package gov.cabinetofice.gapuserservice.web;

import gov.cabinetofice.gapuserservice.config.ApplicationConfigProperties;
import gov.cabinetofice.gapuserservice.dto.OneLoginUserInfoDto;
import gov.cabinetofice.gapuserservice.model.Role;
import gov.cabinetofice.gapuserservice.model.RoleEnum;
import gov.cabinetofice.gapuserservice.model.User;
import gov.cabinetofice.gapuserservice.service.OneLoginService;
import gov.cabinetofice.gapuserservice.service.jwt.impl.CustomJwtServiceImpl;
import jakarta.servlet.http.Cookie;
import jakarta.servlet.http.HttpServletResponse;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.*;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.MockedStatic;
Expand All @@ -20,6 +21,7 @@
import org.springframework.web.servlet.view.RedirectView;
import org.springframework.web.util.WebUtils;

import java.util.List;
import java.util.Optional;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
Expand Down Expand Up @@ -50,6 +52,9 @@ void setUp() {
.build();

loginController = new LoginControllerV2(oneLoginService, customJwtService, configProperties);
ReflectionTestUtils.setField(loginController, "oneLoginBaseUrl", "oneLoginBaseUrl");
ReflectionTestUtils.setField(loginController, "userServiceCookieName", "userServiceCookieName");
ReflectionTestUtils.setField(loginController, "adminBaseUrl", "adminBaseUrl");
}

@AfterEach
Expand All @@ -65,8 +70,6 @@ void shouldRedirectToOneLogin_IfTokenIsNull() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final MockHttpServletRequest request = new MockHttpServletRequest();

ReflectionTestUtils.setField(loginController, "oneLoginBaseUrl", "oneLoginBaseUrl");

final RedirectView methodResponse = loginController.login(redirectUrl, request, response);

final Cookie redirectUrlCookie = new Cookie(LoginController.REDIRECT_URL_COOKIE, redirectUrl.get());
Expand All @@ -85,7 +88,6 @@ void shouldReturnRedirectUrl_IfOneIsProvided_AndTokenIsValid() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final MockHttpServletRequest request = new MockHttpServletRequest();

ReflectionTestUtils.setField(loginController, "userServiceCookieName", "userServiceCookieName");
mockedStatic.when(() -> WebUtils.getCookie(request, "userServiceCookieName"))
.thenReturn(new Cookie(LoginController.REDIRECT_URL_COOKIE, customToken));
when(customJwtService.isTokenValid(customToken))
Expand All @@ -104,12 +106,10 @@ void shouldReturnDefaultRedirectUrl_IfRedirectUrlNotProvided_AndTokenIsValid() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final MockHttpServletRequest request = new MockHttpServletRequest();

ReflectionTestUtils.setField(loginController, "userServiceCookieName", "userServiceCookieName");
mockedStatic.when(() -> WebUtils.getCookie(request, "userServiceCookieName"))
.thenReturn(new Cookie(LoginController.REDIRECT_URL_COOKIE, customToken));
when(customJwtService.isTokenValid(customToken))
.thenReturn(true);

final RedirectView methodResponse = loginController.login(redirectUrl, request, response);

verify(customJwtService, times(0)).generateToken(any());
Expand All @@ -120,24 +120,117 @@ void shouldReturnDefaultRedirectUrl_IfRedirectUrlNotProvided_AndTokenIsValid() {
@Nested
class redirectAfterLogin {

final static Cookie customJwtCookie = new Cookie("userServiceCookieName", "a-custom-valid-token");

@BeforeAll
static void beforeAll() {
customJwtCookie.setSecure(true);
customJwtCookie.setHttpOnly(true);
customJwtCookie.setPath("/");
}

@BeforeEach
void beforeEach() {
when(oneLoginService.getUserInfo(null))
.thenReturn(OneLoginUserInfoDto.builder()
.sub("sub")
.email("email")
.build());
when(customJwtService.generateToken(any()))
.thenReturn("a-custom-valid-token");
}

@Test
void shouldCreateNewUser_WhenNoUserFound() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final Optional<String> redirectUrl = Optional.of("redirectUrl");

when(oneLoginService.getUser("email", "sub"))
.thenReturn(Optional.empty());
when(oneLoginService.createUser("sub", "email"))
.thenReturn(User.builder().build());

final RedirectView methodResponse = loginController.redirectAfterLogin(redirectUrl, response, "a-custom-valid-token");

verify(response).addCookie(customJwtCookie);
verify(oneLoginService).createUser("sub", "email");
assertThat(methodResponse.getUrl()).isEqualTo(redirectUrl.get());
}

@Test
void shouldDoNothing_WhenUserFoundWithSub() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final Optional<String> redirectUrl = Optional.of("redirectUrl");
final User user = User.builder().sub("sub").email("email").build();

when(oneLoginService.getUser("email", "sub"))
.thenReturn(Optional.of(user));

final RedirectView methodResponse = loginController.redirectAfterLogin(redirectUrl, response, "a-custom-valid-token");

verify(response).addCookie(customJwtCookie);
verify(oneLoginService, times(0)).createUser(anyString(), anyString());
verify(oneLoginService, times(0)).addSubToUser(anyString(), anyString());
assertThat(methodResponse.getUrl()).isEqualTo(redirectUrl.get());
}

@Test
void shouldUpdateUser_WhenUserFoundWithoutSub_AndIsAdmin() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final Optional<String> redirectUrl = Optional.of("redirectUrl");
final User user = User.builder().email("email").roles(List.of(
Role.builder().name(RoleEnum.ADMIN).build(),
Role.builder().name(RoleEnum.APPLICANT).build(),
Role.builder().name(RoleEnum.FIND).build()
)).build();

when(oneLoginService.getUser("email", "sub"))
.thenReturn(Optional.of(user));

final RedirectView methodResponse = loginController.redirectAfterLogin(redirectUrl, response, "a-custom-valid-token");

verify(response).addCookie(customJwtCookie);
verify(oneLoginService).addSubToUser("sub", "email");
assertThat(methodResponse.getUrl()).isEqualTo("adminBaseUrl/dashboard");
}

@Test
void shouldUpdateUser_WhenUserFoundWithoutSub_AndIsSuperAdmin() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final Optional<String> redirectUrl = Optional.of("redirectUrl");
final User user = User.builder().email("email").roles(List.of(
Role.builder().name(RoleEnum.SUPER_ADMIN).build(),
Role.builder().name(RoleEnum.ADMIN).build(),
Role.builder().name(RoleEnum.APPLICANT).build(),
Role.builder().name(RoleEnum.FIND).build()
)).build();

when(oneLoginService.getUser("email", "sub"))
.thenReturn(Optional.of(user));

final RedirectView methodResponse = loginController.redirectAfterLogin(redirectUrl, response, "a-custom-valid-token");

verify(response).addCookie(customJwtCookie);
verify(oneLoginService).addSubToUser("sub", "email");
assertThat(methodResponse.getUrl()).isEqualTo("adminBaseUrl/super-admin/dashboard");
}

@Test
void shouldGoToMigrateDataPage_WhenUserFoundWithoutSub_AndIsAnApplicant() {
final HttpServletResponse response = Mockito.spy(new MockHttpServletResponse());
final Optional<String> redirectUrl = Optional.of("redirectUrl");
final User user = User.builder().email("email").roles(List.of(
Role.builder().name(RoleEnum.APPLICANT).build(),
Role.builder().name(RoleEnum.FIND).build()
)).build();

when(oneLoginService.getUser("email", "sub"))
.thenReturn(Optional.of(user));

final RedirectView methodResponse = loginController.redirectAfterLogin(redirectUrl, response, "a-custom-valid-token");

verify(response).addCookie(customJwtCookie);
assertThat(methodResponse.getUrl()).isEqualTo("/should-migrate-data");
}
}
}

0 comments on commit e4aa3f1

Please sign in to comment.