Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMI2-512-code-clean-up #82

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Conversation

IlyasBaqqari-CabinetOffice
Copy link
Contributor

@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice commented Dec 18, 2023

Description

TMI2-512

As per the ticket, I have went through the code making improvements where possible.

The Project Error Analysis feature of IntelliJ flagged hundreds of warnings, however a large portion of these were false positives. I have narrowed down the genuine warnings wherever I can, implementing fixes such as:

  • Removing unnecessary variables and imports
  • Fixing typos
  • Formatting improvements
  • Other general improvements to the code

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice changed the title Code quality improvements TMI2-512-code-clean-up Dec 18, 2023
@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice marked this pull request as ready for review December 20, 2023 16:54
@@ -84,6 +84,7 @@ public class GrantMandatoryQuestions extends BaseEntity {
private BigDecimal fundingAmount;

@Column(name = "funding_location")
// TODO - Ask Jim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you want to ask me? ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent you a message!

@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice merged commit 6342411 into develop Jan 5, 2024
1 check passed
@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice deleted the TMI2-512-code-clean-up branch January 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants