Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-1596: properly sort error messages from back end #129

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

GavCookCO
Copy link
Contributor

@GavCookCO GavCookCO commented Mar 21, 2024

Description

Fixing the sort order on question responses where multiple errors may appear on the screen at once. Previously these were just displayed in whatever order the code encountered the validation error but now they appear in the same order as the form.

Ticket # and link
GAP-1596

Summary of the changes and the related issue. List any dependencies that are required for this change:
Added a couple of methods to the controller exception handler to sort messages before they are returned back through the API

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@GavCookCO GavCookCO changed the title GAP-1596: properly sort error messages from back end DRAFT GAP-1596: properly sort error messages from back end Mar 21, 2024
@GavCookCO GavCookCO marked this pull request as ready for review March 25, 2024 12:57
@GavCookCO GavCookCO changed the title DRAFT GAP-1596: properly sort error messages from back end GAP-1596: properly sort error messages from back end Mar 26, 2024
Copy link
Contributor

@paul-lawlor-tco paul-lawlor-tco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left minor comment - happy to approve whether it gets implemented or not!

@ConorFayleTCO ConorFayleTCO merged commit 3c79c67 into develop Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants