Merge pull request #40 from caarlos0/fix

fix unexported inner structs
caarlos0 · Oct 30, 2017 · 9de094f · 9de094f
2 parents d29d8d2 + cb3993a
commit 9de094f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/env.go b/env.go
@@ -45,7 +45,7 @@ func doParse(ref reflect.Value) error {
 	var errorList []string
 
 	for i := 0; i < refType.NumField(); i++ {
-		if reflect.Ptr == ref.Field(i).Kind() {
+		if reflect.Ptr == ref.Field(i).Kind() && ref.Field(i).CanSet() {
 			err := Parse(ref.Field(i).Interface())
 			if nil != err {
 				return err

diff --git a/env_test.go b/env_test.go
@@ -31,6 +31,7 @@ type Config struct {
 
 type ParentStruct struct {
 	InnerStruct *InnerStruct
+	unexported  *InnerStruct
 }
 
 type InnerStruct struct {
@@ -77,16 +78,14 @@ func TestParsesEnv(t *testing.T) {
 }
 
 func TestParsesEnvInner(t *testing.T) {
-
 	os.Setenv("innervar", "someinnervalue")
 	defer os.Clearenv()
-	cfg := ParentStruct{&InnerStruct{}}
+	cfg := ParentStruct{&InnerStruct{}, &InnerStruct{}}
 	assert.NoError(t, env.Parse(&cfg))
 	assert.Equal(t, "someinnervalue", cfg.InnerStruct.Inner)
 }
 
 func TestParsesEnvInnerNil(t *testing.T) {
-
 	os.Setenv("innervar", "someinnervalue")
 	defer os.Clearenv()
 	cfg := ParentStruct{}