Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy arm64 #1374

Closed
wants to merge 3 commits into from
Closed

Numpy arm64 #1374

wants to merge 3 commits into from

Conversation

nightscape
Copy link

No description provided.

@nightscape nightscape force-pushed the numpy-arm64 branch 2 times, most recently from 0913450 to 42d9a6f Compare June 13, 2023 19:31
@saudet
Copy link
Member

saudet commented Jun 14, 2023

It's not building for the arm64 architecture. You'll need to fix that

@nightscape
Copy link
Author

nightscape commented Jun 14, 2023

@saudet afaiu, this PR depends on the cpython-arm64 PR getting merged and artifacts being published, right?
At least right now it seems to be failing because it can't resolve the cpython artifacts.

@saudet
Copy link
Member

saudet commented Jun 14, 2023 via email

@nightscape
Copy link
Author

Sorry, I think I'm not understanding something.
Have you had a look at #1373 ?
I introduced a cpython-arm64 build there and the corresponding Github action says it's building successfully.
Can we continue the discussion on #1373 ?

@saudet saudet changed the base branch from master to cpython June 14, 2023 11:14
@saudet
Copy link
Member

saudet commented Jun 14, 2023

I see, let's work on that in another branch. I've merged what you had in the cpython branch, and it got deployed as snapshots.

@saudet
Copy link
Member

saudet commented Jul 13, 2023

Good news! We can use crossenv==1.4.0 to cross compile with CPython 3.11. I don't know if it works with Mac, but it works for Linux, see pull #1386, so please give it a try.

@saudet
Copy link
Member

saudet commented Oct 18, 2023

I've upgraded the builds for NumPy that now use Meson instead of distutils. It should make it easier to cross compile, so if you'd like to give it another shot: https://numpy.org/doc/stable/user/building.html#cross-compilation

@nightscape
Copy link
Author

@saudet just to understand correctly (sorry if this is a stupid question):
You upgraded to a NumPy version that supports Meson, but (judging from my limited understanding of Meson that it would not use all these ..._PATH variables) the corresponding numpy/cppbuild.sh still uses the old build system, right?
Would I adapt the numpy/cppbuild.sh to use Meson for all platforms as described here?

@nightscape
Copy link
Author

I fear I'm in way over my head here...
I'm trying to wrap my head around how all the Python, C and C++ build tools interact with each other, but I'm a spoiled little JVM child and don't seem to be able to understand all that stuff with LIB_PATHs, compiler flags, cross-compilation, ...

@saudet
Copy link
Member

saudet commented Oct 21, 2023 via email

@saudet
Copy link
Member

saudet commented Feb 1, 2024

Looks like GitHub Actions now has free M1 runners. Want to give this a try again with that? https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

@saudet
Copy link
Member

saudet commented Jun 29, 2024

Duplicate of #1515

@saudet saudet marked this as a duplicate of #1515 Jun 29, 2024
@saudet saudet closed this Jun 29, 2024
@nightscape nightscape deleted the numpy-arm64 branch June 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants