Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotate options in javascript #169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bastienmoulia
Copy link

@bastienmoulia bastienmoulia changed the title Change licence to a valid name Add rotate options in javascript Nov 30, 2015
@bastienmoulia
Copy link
Author

I had to disable the header banner in gulp because it crash.

@bumbu
Copy link
Owner

bumbu commented Dec 6, 2015

Great work @bastienmoulia !
You didn't have to commit dist files, but this is easy to fix. It will be great to add tests and demos. Without demos it will be hard for other users to understand how it works.

I'll take a look other this commit in more detail over next days.

@ariutta can you please confirm that that's the right version of BSD license? The complete list is here.

Thanks!

@jeremyVignelles
Copy link
Contributor

Had the same header issue and made a fix in #178 . I don't know exactly how this will merge.

bumbu pushed a commit that referenced this pull request Dec 21, 2015
bumbu added a commit that referenced this pull request Dec 21, 2015
@ariutta ariutta mentioned this pull request Jan 10, 2016
34 tasks
@Yimiprod
Copy link
Collaborator

Yimiprod commented Jan 9, 2017

@bumbu since this PR is almost 1 year old, should we keep it open?

@bastienmoulia
Copy link
Author

If this fonction is needed i can make a new PR with an updated version.

@ariutta
Copy link
Collaborator

ariutta commented Oct 29, 2019

@bastienmoulia and @bumbu, I apologize for the delay here. I'm sorry that I don't really have the bandwidth to properly review pull requests for new features right now.

@Yimiprod, I invited you to be a collaborator. You and any of the other collaborators can feel free to manage issues and pull requests, using your best judgment.

@aleofreddi, you originally specified a BSD license. Is BSD-2-Clause correct?

@shadowjustice
Copy link

shadowjustice commented Jan 21, 2020

Hi,

As a big time user of this extension in angular is there any view on when this will be merged?

Can I merge these files locally myself?

Br,

Tom

@shadowjustice
Copy link

shadowjustice commented Feb 4, 2020

Hi i finally got my fork running by upgrading to gulp v 4 (node 12 +) I tested this pull request and it works!

EDIT: Since this pull request is so old I will try based on this one to make a new one with the rotate option. (which do not have conflicts)

var that = this
, s = 'matrix(' + matrix.a + ',' + matrix.b + ',' + matrix.c + ',' + matrix.d + ',' + matrix.e + ',' + matrix.f + ')';

if (rotate.angle !== 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep rotation optional:

if(rotate && typeof rotate.angle === "number" && rotate.angle !== 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants