Move static graphql navigation out of generation script #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://2953--bk-docs-preview.netlify.app |
dannymidnight
force-pushed
the
move-static-graphql-nav
branch
from
163a6d5
to
7718acf
Compare
github-actions
bot
added
pipelines
|
Do not merge until #2932 is merged in first. |
github-actions
bot
removed
pipelines
gilesgas
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks very much @dannymidnight for preparing this!
I've tested that it works (based on the preview) and I also had to remove the redundant checks to get the spec checks in the docs build process to pass.
Please feel free to merge anytime!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves all of the static links to GraphQL related pages out of the generation script.
This simplifiies the process of adding new GraphQL pages, consolidating changes to the
nav.ymland no longer require a user to update the specs.