Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper mouse selection scrolling implementation. Fixes #645 #675

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Proper mouse selection scrolling implementation. Fixes #645 #675

merged 1 commit into from
Sep 18, 2023

Conversation

Ermiq
Copy link
Contributor

@Ermiq Ermiq commented Sep 16, 2023

Properly implemented EditLine horizontal scrolling and EditBox scrolling (both vertical and horizontal) when selection with mouse is active and the caret goes outside of the edit widget boundaries.

  • Reverted back the changes made in editors.d in Fix #645, fix #673 #674
  • Slightly changed the behavior of horizontal scrolling. Replaced hardcoded gap values used to show ~4 symbols ahead of the selection's right edge with _spaceWidth * 4.

Properly implemented `EditLine` horizontal scrolling and `EditBox` scrolling (both vertical and horizontal) when selection with mouse is active and the caret goes outside of the edit widget boundaries.
@GrimMaple
Copy link
Collaborator

Thank you! :)

@GrimMaple GrimMaple merged commit 7af5a9a into buggins:master Sep 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants