New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message and field name to binary serialization errors #984

Open

bhollis wants to merge 1 commit into bufbuild:main from StatelyCloud:to-binary-error-details

bhollis commented Oct 3, 2024

This adds the message and field name to errors thrown during binary serialization of scalar fields. It should convert a message like:

Error: invalid uint32: -1

To:

Error: cannot encode field com.whatever.MyMessage.my_field to binary: invalid uint32: -1

I followed the wording of the error thrown here for the phrasing: https://github.com/bufbuild/protobuf-es/blob/main/packages/protobuf/src/to-binary.ts#L74

Fixes #983


          Add message and field name to binary serialization errors

3e5113d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet