Rename utility methods #reset and #verify to reset_rr and verify_rr to avoid clashes with other methods in Cucumber's World namespace #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid clashes with other methods in the cucumber World namespace, e.g. Gherkin::Formatter::AnsiEscapes#reset
|
Hey there. This seems like a plausible issue, however, using RR (or any mocking library, for that matter) with Cucumber is not really recommended. I realize this is late but is there (or was there) a specific reason you were doing this? Also, is this still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. Gherkin::Formatter::AnsiEscapes#reset
Specifically I ran into an exception from this line in cucumber's lib/cucumber/rb_support/rb_world.rb:
Specs pass. Seems to me that these 2 methods would be better off properly namespaces, and the Gherkin AnsiEscapes methods should do the same. Thoughts?