Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test cargo test #556

Closed
wants to merge 68 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
5d36b91
Fix cargo login token tests
psibi Aug 18, 2023
e3ebab3
Remove rust-ts-mode from auto-mode-alist
psibi Feb 18, 2024
866c5e2
Fix possible babel test failures
psibi Feb 18, 2024
a4fbc1b
Change regex for rustic-test-babel-error-results
psibi Feb 18, 2024
9a6ddd0
No issue with compile error
psibi Feb 18, 2024
8620a98
Do fixes at other locations too
psibi Feb 18, 2024
fd5b5d8
Merge pull request #2 from psibi/babel-test-failures
psibi Feb 18, 2024
4002826
Enable test for emacs 29.1
psibi Feb 18, 2024
c6cd30f
Bump version of cask
psibi Feb 18, 2024
a743dd7
Try using ert tests
psibi Feb 18, 2024
5a36ba4
Require test-helper
psibi Feb 18, 2024
36077a2
Add load-file
psibi Feb 18, 2024
b56aba0
Update depedency
psibi Feb 18, 2024
0b03616
Add melpa check
psibi Feb 18, 2024
de38bba
Update
psibi Feb 18, 2024
c64e2fb
Fix seq version
psibi Feb 18, 2024
e784003
seq is included with Emacs 25
psibi Feb 18, 2024
408adb1
Remove seq
psibi Feb 18, 2024
69b02b4
Do relevant imports for rustic-cargo-test
psibi Feb 18, 2024
038c4f6
Modify test setup for Emacs 29.1
psibi Feb 19, 2024
ebee470
Slight cleanup
psibi Feb 19, 2024
498e7b7
Update tests
psibi Feb 19, 2024
5654d66
Switch the compilation error count to 1
psibi Feb 19, 2024
91731e8
Revert it back to 10
psibi Feb 19, 2024
6da5f7b
Remove should-not
psibi Feb 19, 2024
c726954
Simplify github action
psibi Feb 19, 2024
3748f6d
Revert test numbers
psibi Feb 19, 2024
2621065
Add changelog
psibi Feb 19, 2024
6c2f266
Try fixing flaky tests
psibi Feb 19, 2024
ecd95ed
Fix one more flaky test
psibi Feb 19, 2024
5c1cff5
Merge pull request #3 from psibi/emacs-20
psibi Feb 19, 2024
adf3690
Update changelog
psibi Feb 19, 2024
5fb361c
Update pinned rustc to latest stable
psibi Feb 19, 2024
ccd6df0
Merge pull request #4 from psibi/rustc-1.76
psibi Feb 19, 2024
331968e
Fix rustic-cargo-outdated
psibi Feb 23, 2024
6d00f85
Update changelog
psibi Feb 23, 2024
89b3350
Try fixing flaky test
psibi Feb 23, 2024
9f13601
Merge pull request #5 from psibi/outdated-fix
psibi Feb 23, 2024
37d033f
Remove racer integration
psibi Feb 24, 2024
ae570c3
Fix flakey test
psibi Feb 24, 2024
d91e31c
Fix buffer name
psibi Feb 24, 2024
8baf2e5
Fix another flaky test
psibi Feb 24, 2024
363903a
Fix another flaky test
psibi Feb 24, 2024
ee6cffa
Update test badge
psibi Feb 24, 2024
a98a624
Merge pull request #6 from psibi/remove-racer
psibi Feb 24, 2024
86930b4
CI: Test against emacs 29.2
psibi Feb 24, 2024
efdb033
Fix more flaky tests
psibi Feb 24, 2024
282d2c1
Merge pull request #7 from psibi/ci-29.2
psibi Feb 24, 2024
baae890
Update docs
psibi Feb 24, 2024
09615eb
Merge pull request #8 from psibi/docs-install
psibi Feb 24, 2024
e5fb2ab
Add docs for tree-sitter
psibi Feb 27, 2024
5a90c7e
Update rustic link
psibi Feb 27, 2024
a243bdd
Fix flaky test
psibi Feb 27, 2024
b0da291
Merge pull request #9 from psibi/docs-install
psibi Feb 27, 2024
3a8c555
Fix bugs related to tree sitter integration
psibi Feb 27, 2024
41996b1
Fix flaky tests
psibi Feb 27, 2024
937e9db
Merge pull request #10 from psibi/tree-sitter-fix
psibi Feb 27, 2024
ffd070c
Make rustic-cargo-clippy remember it's universal arguments
psibi Feb 28, 2024
07fff49
Merge pull request #12 from psibi/clippy-fix
psibi Feb 28, 2024
745a748
Fix flaky clippy test
psibi Feb 29, 2024
4dac7f3
Merge pull request #13 from psibi/clippy-fix-test
psibi Feb 29, 2024
8bb15c7
Update docs
psibi Mar 2, 2024
4131d8f
Merge pull request #14 from psibi/update-docs
psibi Mar 2, 2024
346a64b
Improve minibuffer population
psibi Mar 27, 2024
7635ca2
Check using s-blank for empty strings
psibi Mar 27, 2024
50ac403
Update changelog
psibi Mar 27, 2024
e556c87
Merge pull request #17 from psibi/populate-improve
psibi Mar 27, 2024
9ed58ec
Fix flaky tests
psibi Mar 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 38 additions & 48 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,51 +3,41 @@ name: CI
on: [push, pull_request]

jobs:
unix-test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
emacs-version:
- 27.2
- 28.1
steps:
- uses: actions/checkout@v2

- uses: purcell/setup-emacs@master
with:
version: ${{ matrix.emacs-version }}

- uses: conao3/setup-cask@master
with:
version: 0.8.4

- name: Install requirements
run: |
echo "$HOME/.cask/bin" >> $GITHUB_PATH
echo "$HOME/bin" >> $GITHUB_PATH

sudo apt update
sudo apt install -y gnutls-bin gnupg2 dirmngr
sudo apt install -y texinfo libgif-dev libxpm-dev

- name: Install needed rust stuff
run: |
curl -sSf https://build.travis-ci.com/files/rustup-init.sh | sh -s -- --default-toolchain=stable -y
source $HOME/.cargo/env
rustup component add rustfmt-preview

- name: rustic-doc prerequisites
run: |
wget https://github.com/jgm/pandoc/releases/download/2.17.0.1/pandoc-2.17.0.1-1-amd64.deb
sudo dpkg -i pandoc-2.17.0.1-1-amd64.deb
mkdir -p ~/.local/bin
mkdir -p ~/.local/share/emacs/rustic-doc/std/
curl -sL https://github.com/sharkdp/fd/releases/download/v8.3.2/fd-v8.3.2-x86_64-unknown-linux-musl.tar.gz | tar xz --wildcards --strip-components=1 -C /usr/local/bin '*/fd'
curl -sL https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz | tar xz --wildcards --strip-components=1 -C /usr/local/bin '*/rg'
rustup component add rust-docs

- name: Run tests
run: |
make test
unix-test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
emacs-version:
- 27.2
- 28.1
- 29.1
- 29.2
steps:
- uses: actions/checkout@v4
- uses: taiki-e/install-action@v2
with:
tool: [email protected]
- uses: purcell/setup-emacs@master
with:
version: ${{ matrix.emacs-version }}

- uses: cask/setup-cask@v1
with:
version: 0.9.0

- name: Install requirements
run: |
echo "$HOME/.cask/bin" >> $GITHUB_PATH
echo "$HOME/bin" >> $GITHUB_PATH

- uses: dtolnay/rust-toolchain@master
with:
toolchain: 1.76.0
components: clippy, rustfmt

- name: Run tests
run: |
just build
just test
19 changes: 19 additions & 0 deletions CHANGELOG.org
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
* Unreleased

- Revamp testing in CI: Use only cask.
- Replace Makefile with justfile.
- Pin Rust version in CI to avoid spurious failure.
- Create a new babel variable to create temporary directory and not
rely on babel's internal stuff. This was needed to fix the tests.
- Fix flaky tests.
- Enable tests for Emacs 29.1
- Update rustc to 1.76.0
- Fix bugs in rustic-cargo-outdated mode in the presence of git
repositories as dependency.
- Remove racer integrace since it's development has been discontinued.
- Enable tests for Emacs 29.2
- Add fixes for enabling tree sitter support from rust-mode.
- Make ~rustic-cargo-clippy~ remember it's universal arguments.
- Populate minibuffer entries for ~rustic-cargo-clippy~ and
~rustic-cargo-build~ with it's previous entry.
- Fix integration with lsp-mode during format of buffers.
153 changes: 0 additions & 153 deletions Makefile

This file was deleted.

Loading
Loading