Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] call parent method in eglot-initialization-options #505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[bugfix] call parent method in eglot-initialization-options #505

wants to merge 1 commit into from

Commits on Apr 26, 2023

  1. [bugfix] call parent method in eglot-initialization-options 

    (eglot-initialization-options) is a cl-defgeneric overridable method with a default implementation, and our code was overriding it but not calling the default implementation. 

This means that any core eglot logic around initialization options was failing to run, which had a user-visible consequence that the initializationOptions behaviour described in https://joaotavora.github.io/eglot/#User_002dspecific-configuration was not happening.
    @SohumB
    SohumB authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ed80d84 View commit details
    Browse the repository at this point in the history