Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jackson module for serialization and deserialization #3

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Add jackson module for serialization and deserialization #3

merged 5 commits into from
Jun 27, 2023

Conversation

miensol
Copy link
Member

@miensol miensol commented Jun 23, 2023

No description provided.

@azabost azabost self-requested a review June 24, 2023 23:00
azabost
azabost reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@azabost azabost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 💪

The only blocker IMO is the comment about the package names.

jackson/src/main/kotlin/dev/codified/jackson/CodifiedDeserializer.kt Outdated Show resolved Hide resolved
jackson/src/main/kotlin/dev/codified/jackson/CodifiedDeserializer.kt Outdated Show resolved Hide resolved
jackson/src/test/kotlin/dev/codified/jackson/CodifiedJacksonModuleTest.kt Outdated Show resolved Hide resolved
jackson/src/test/kotlin/dev/codified/jackson/CodifiedJacksonModuleTest.kt Outdated Show resolved Hide resolved
jackson/src/main/kotlin/dev/codified/jackson/CodifiedDeserializer.kt Outdated Show resolved Hide resolved
jackson/src/test/kotlin/dev/codified/jackson/CodifiedJacksonModuleTest.kt Outdated Show resolved Hide resolved
jackson/src/main/kotlin/dev/codified/jackson/CodifiedJacksonModule.kt Outdated Show resolved Hide resolved
@azabost
Copy link
Member

azabost commented Jun 25, 2023

Ah, one more thing. Could you also briefly describe how to use the Jackson serialization support in README, please?

@miensol
Copy link
Member Author

miensol commented Jun 26, 2023

Ah, one more thing. Could you also briefly describe how to use the Jackson serialization support in README, please?

I'd love to but in separate PR. I'd like first to try to use it in a project to see a set up in a more complex environment (i.e. Spring Boot).

@azabost azabost merged commit 2eb18ef into master Jun 27, 2023
2 checks passed
@azabost azabost deleted the jackson-module branch June 27, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azabost azabost azabost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miensol @azabost