Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo publishing workflow #73

Merged
merged 2 commits into from
Jul 1, 2023
Merged

redo publishing workflow #73

merged 2 commits into from
Jul 1, 2023

Conversation

briantist
Copy link
Owner

Resolves #70

  • splits the release job into 3 separate jobs
    • the main reason for this is to give least permission to each of the job types
    • the job types are "container" (build and push to ghcr), "pypi" (publish to pypi), and "github" (creating the release page)
  • the pypi publish now uses OIDC (trusted publisher) integration, so once confirmed working I can revoke the token I generated and remove that secret from the repo settings

@briantist briantist added the github_actions Pull requests that update GitHub Actions code label Jul 1, 2023
@briantist briantist self-assigned this Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (95a604f) 56.70% compared to head (f7e499a) 56.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   56.70%   56.59%   -0.11%     
==========================================
  Files          26       26              
  Lines         947      947              
==========================================
- Hits          537      536       -1     
- Misses        410      411       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@briantist briantist merged commit 17b9823 into main Jul 1, 2023
11 checks passed
@briantist briantist deleted the pypi/trusted-publisher branch July 1, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyPI publishing to use OIDC / Trusted Publishing
1 participant