Fix URL quoting for collection info (#72)

* bump dohq-artifactory

* quote URL parameters

* bump dohq-artifactory in setup.cfg

* add changelog fragment

* update changelog fragment

changelogs/fragments/72-fix-url-quoting.yml

@@ -0,0 +1,9 @@
+---
+minor_changes:
+  - the minimum required version of ``dohq-artifactory`` is now ``v0.9.0`` (https://github.com/briantist/galactory/pull/72).
+
+bugfixes:
+  - traceback when publishing or retrieving a previously published collection (even by proxying) whose metadata contains certain characters that need to be URL quoted (https://github.com/briantist/galactory/issues/58, https://github.com/briantist/galactory/issues/52).
+
+known_issues:
+  - any collections already published with malformed metadata due to the bug in ``collection_info`` will not be fixed and will need to be re-published or have their collection info repaired (https://github.com/briantist/galactory/pull/72).

galactory/upstream.py

@@ -145,7 +145,7 @@ def _set_cache(self, request, cache) -> None:
             cache.update()
             json.dump(cache._to_serializable_dict(), buffer, default=DateTimeIsoFormatJSONProvider.default)
             buffer.seek(0)
-            path.deploy(buffer)
+            path.deploy(buffer, quote_parameters=True)
 
     @contextmanager
     def proxy_download(self, request):

galactory/utilities.py

@@ -260,7 +260,14 @@ def upload_collection_from_hashed_tempfile(artifact: ArtifactoryPath, tmpfile: H
         params = {}
 
     try:
-        artifact.deploy(tmpfile.handle, md5=tmpfile.md5, sha1=tmpfile.sha1, sha256=tmpfile.sha256, parameters=params)
+        artifact.deploy(
+            tmpfile.handle,
+            md5=tmpfile.md5,
+            sha1=tmpfile.sha1,
+            sha256=tmpfile.sha256,
+            parameters=params,
+            quote_parameters=True
+        )
     except ArtifactoryException as exc:
         cause = exc.__cause__
         current_app.logger.debug(cause)

requirements.txt

@@ -1,4 +1,4 @@
-dohq-artifactory>=0.8,<0.9
+dohq-artifactory>=0.9,<0.10
 Flask>=2.1,<3
 semver>=2,<3
 base64io>=1,<2

setup.cfg

@@ -28,7 +28,7 @@ zip_safe = True
 include_package_data = True
 python_requires = >= 3.6
 install_requires =
-    dohq-artifactory>=0.8,<0.9
+    dohq-artifactory>=0.9,<0.10
     Flask>=2.1,<3
     semver>=2,<3
     base64io>=1,<2