Merge pull request #3014 from briannesbitt/fix/issue-3006-set-test-now

Fallback to default timezone for mocked now
briannesbitt · May 1, 2024 · 8ff64b9 · 8ff64b9
2 parents 3daf68d + e89692a
commit 8ff64b9
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/Carbon/Traits/Test.php b/src/Carbon/Traits/Test.php
@@ -148,8 +148,8 @@ private function mockConstructorParameters(&$time, ?CarbonTimeZone $timezone): v
             return;
         }
 
-        if ($timezone) {
-            $testInstance = $testInstance->setTimezone($timezone);
+        if ($testInstance instanceof DateTimeInterface) {
+            $testInstance = $testInstance->setTimezone($timezone ?? date_default_timezone_get());
         }
 
         if (static::hasRelativeKeywords($time)) {

diff --git a/tests/Carbon/TestingAidsTest.php b/tests/Carbon/TestingAidsTest.php
@@ -391,6 +391,23 @@ public function modify($modify)
         $this->assertSame('2000-01-02 00:00:00 UTC', $currentTime->format('Y-m-d H:i:s e'));
     }
 
+    public function testTimezoneConsistency()
+    {
+        Carbon::setTestNow();
+        date_default_timezone_set('UTC');
+        $currentDate = Carbon::now()->setTimezone('America/Los_Angeles');
+        $laDate = $currentDate->format('Y-m-d H:i:s e');
+        $utcDate = $currentDate->copy()->utc()->format('Y-m-d H:i:s e');
+
+        Carbon::setTestNow($currentDate);
+        $this->assertSame($utcDate, Carbon::now()->format('Y-m-d H:i:s e'));
+        $this->assertSame($utcDate, Carbon::now('UTC')->format('Y-m-d H:i:s e'));
+
+        Carbon::setTestNowAndTimezone($currentDate);
+        $this->assertSame($laDate, Carbon::now()->format('Y-m-d H:i:s e'));
+        $this->assertSame($utcDate, Carbon::now('UTC')->format('Y-m-d H:i:s e'));
+    }
+
     public function testSleep()
     {
         $initial = Carbon::now('UTC');