Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency adblock-rs to v0.9.0 #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 2, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
adblock-rs 0.8.12 -> 0.9.0 age adoption passing confidence

Release Notes

brave/adblock-rust (adblock-rs)

v0.9.0

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

[puLL-Merge] - brave/[email protected]

Description

This PR makes significant changes to the adblock-rust library, updating it from version 0.8.12 to 0.9.0. The changes include improvements in handling cosmetic filters, scriptlet resources, and overall code structure. Key modifications include:

  1. Enhanced support for procedural cosmetic filters
  2. Improved scriptlet resource handling with dependency management
  3. Updates to the serialization and deserialization formats
  4. Various code refactorings and optimizations

Possible Issues

  1. The changes to cosmetic filter handling may affect existing integrations that rely on the previous behavior.
  2. The new scriptlet resource handling with dependencies might introduce unexpected behaviors if not properly tested with all possible scenarios.

Security Hotspots

No significant security vulnerabilities were identified in this change. However, the following areas should be carefully reviewed:

  1. The new scriptlet resource handling with dependencies (in src/resources/resource_storage.rs) to ensure it doesn't introduce any potential security risks through unexpected resource loading or execution.
  2. The changes to cosmetic filter parsing and handling (in src/filters/cosmetic.rs) to verify that they don't introduce any vulnerabilities in filter processing.
Changes

Changes

  1. Cargo.toml and Cargo.lock:

    • Updated version to 0.9.0
    • Made serde_json a required dependency instead of optional
  2. src/cosmetic_filter_cache.rs:

    • Refactored UrlSpecificResources struct to use a more generic procedural_actions field instead of separate fields for different types of actions
    • Updated CosmeticFilterCache to handle procedural filters
  3. src/filters/cosmetic.rs:

    • Added support for procedural cosmetic filter operators
    • Refactored CosmeticFilter struct to use a vector of CosmeticFilterOperator instead of a single selector string
    • Updated parsing and validation logic for cosmetic filters
  4. src/resources/resource_storage.rs:

    • Implemented dependency handling for scriptlet resources
    • Added get_scriptlet_resources method to handle multiple script injections
    • Updated get_scriptlet_resource to handle dependencies
  5. src/engine.rs:

    • Updated to use the new scriptlet resource handling
  6. Various other files:

    • Updated to accommodate the changes in cosmetic filter and scriptlet resource handling
    • Made minor improvements and refactorings throughout the codebase

Overall, this PR represents a significant update to the adblock-rust library, improving its capabilities in handling cosmetic filters and scriptlet resources. The changes appear to be well-thought-out and include appropriate test updates. However, due to the scope of the changes, thorough testing and careful review of the modifications are recommended to ensure they don't introduce any regressions or unexpected behaviors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants