add .local addresses in when detecting local resource requests #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pes10k
requested review from
antonok-edm and
ryanbr
and removed request for
antonok-edm
pes10k
force-pushed
the
block-requests-to-localhost-with-local
branch
from
0438c0b
to
316c4ef
Compare
pes10k
force-pushed
the
block-requests-to-localhost-with-local
branch
from
316c4ef
to
ef7f944
Compare
antonok-edm
reviewed
Sep 16, 2020
There was a problem hiding this comment.
Blocked on brave/adblock-rust#138 (which should make it into Brave release before we update this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second half of fix for #462