Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube quality android #1944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

youtube quality android #1944

wants to merge 1 commit into from

Conversation

tapanmodh
Copy link

Related to issue: brave/brave-browser#32842
Brave-core PR: brave/brave-core#24164
Adblock-resource PR: brave/adblock-resources#196

@ShivanKaul
Copy link
Collaborator

This rule will apply immediately across all Brave versions, whereas brave/brave-core#24164 will only go into Nightly. Is that the intention?

@tapanmodh
Copy link
Author

This rule will apply immediately across all Brave versions, whereas brave/brave-core#24164 will only go into Nightly. Is that the intention?

Is it? We need it with brave/brave-core#24164 as this PR handles settings for that. Can we apply this rule to only Nightly first?

@ryanbr
Copy link
Collaborator

ryanbr commented Aug 26, 2024

Maybe apply to specifically m.youtube.com to limit the scope to mobile only

@ShivanKaul
Copy link
Collaborator

Can we apply this rule to only Nightly first?

There's no way to apply a filter rule to a particular channel. You could however create a new list and enable it on Nightly via Griffin, see: https://github.com/brave/brave-core/pull/22858/files
This issue captures the series of steps for introducing a new list, adding it to the filter catalog, and selectively turning it on in a specific channel: brave/brave-browser#36244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants