Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic page margins v2 #2458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Trim
Copy link

@Trim Trim commented Jul 26, 2022

This pull request is a port of original work of @seahorsepip in pull request #1746

This rework is rebuild on 0.3 version, it adds some unit tests for new helpers and it has integration tests following comments in original pull request #1746.

For the request of having access to pageCount from the function, I think it's not possible, because pageMargins() is called on each page initialization and so the pageCount is still changing.

@Trim
Copy link
Author

Trim commented Jul 26, 2022

I wasn't sure if I had to add /build automatic modifications within the pull request.
I can remove the commit with these modifications if needed.

Trim added 2 commits July 26, 2022 22:29
This function will receive the pageNumber as argument.

This commit is a port of original work of @seahorsepip in pull request bpampuch#1746

This rework is rebuild on 0.3 version, it adds some unit tests for
new helpers and it has integration tests following comments in original
pull request bpampuch#1746.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant