attachments embedding with text #956 #2234
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionality to embed attachments with
{ text: '', linkToFile: … }
as well as Line.optimizeInlines() in order to minimize the number of fileAnnotations per line of text.(Works great with
{ style: 'icon' }
!)I'm not 100% confident that optimizeInlines doesn't break in some cases, but it seems to work perfectly for everything I tested - tests run as well.