Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Update qt example #1307

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

barendgehrels
Copy link
Collaborator

Recently I updated wxwidget example.
Similarly, this PR updates the qt example.
It's now simple to install on Mac, using brew

The first example x01 was nearly the same as the other x06 so the first is omitted.

Example of running it.

./qt_world_mapper.app/Contents/MacOS/qt_world_mapper ../../../../test/algorithms/buffer/data/gr.wkt

image

@@ -34,6 +33,8 @@
#include "wx/dcgraph.h"
#endif

#include "common/read_countries.hpp"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They now share code

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

I managed to build and run in Ubuntu 22 (although not that straightforward ;)

First, Vulkan SDK was needed (see here).

Then I had several issues with qt local setup which I will not post here because it was probably due to my setup and not applicable to other users.

Something that should be mentioned in this PR is the dependency upgrade from qt4 to qt6. In particular, QT6.3 which introduces qt_standard_project_setup() command. For example, ubuntu 22 has QT6.2.4 thus I replaced qt_standard_project_setup() with

set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTOUIC ON)
set(CMAKE_AUTORCC ON)

@barendgehrels
Copy link
Collaborator Author

Thanks for testing! Will update the README and consult you

@barendgehrels
Copy link
Collaborator Author

BTW I could build it without vulcan. But also with brew install vulkan-tools. Will add that also

@barendgehrels
Copy link
Collaborator Author

@vissarion I updated the readme according to your findings. Is this OK?

@vissarion
Copy link
Member

BTW I could build it without vulcan. But also with brew install vulkan-tools. Will add that also

That could be also possible in ubuntu, I didn't chech, I just show the warning and fix it by installing vulcan.

@vissarion I updated the readme according to your findings. Is this OK?

Thanks, I am OK!

@barendgehrels
Copy link
Collaborator Author

That could be also possible in ubuntu, I didn't chech, I just show the warning and fix it by installing vulcan.

OK, I rephrase it a bit, adding "might", and merge, thanks!

@barendgehrels barendgehrels merged commit 6c17350 into boostorg:develop Sep 13, 2024
23 checks passed
@barendgehrels barendgehrels deleted the example/qt branch September 13, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants