Add basic tests, and fix some DAISY2 handling #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the "spine" (play order) is stable, by dumping it from test books. Books are from various locations, removing any actual recording not necessary for the tests, and possibly copyrighted. All that is left should be assumed meta-data, and be fair-use.
Remove handling of <text> nodes that don't seem to make sense in audio reading, but leads the parser down a rabbit hole and skipping further content in that file. This got introduced in c01216f, probably as a refactoring trying to merge daisy-player and ebook-speaker codebases.
|
I added a TERM fix and included it in CI, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce basic testing for how the file's "spine" is loaded.
It also introduces 4 tests based on real-world DAISY files, with audio and relevant test stripped/redacted hopefully not to irritate anybody (everything there is is the file's structure and general details like e.g. TOC).
It finally introduces a fix for reading some DAISY2 files (the examples there just couldn't be read with >+ 10.4. I can of course split this out to another PR if you think it's better.