Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests from WPT and fix them in the Console #3979

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 3, 2024

Also added as_regexp() in JsValue as I needed it for the boa_wpt branch. Merged that in this PR.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 82.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.02%. Comparing base (6ddc2b4) to head (4dd3571).
Report is 258 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/src/console/mod.rs 89.85% 7 Missing ⚠️
core/engine/src/value/mod.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3979      +/-   ##
==========================================
+ Coverage   47.24%   52.02%   +4.78%     
==========================================
  Files         476      468       -8     
  Lines       46892    45329    -1563     
==========================================
+ Hits        22154    23584    +1430     
+ Misses      24738    21745    -2993     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raskad raskad added this to the next-release milestone Sep 10, 2024
@raskad raskad requested a review from a team September 10, 2024 23:39
@jedel1043 jedel1043 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into boa-dev:main with commit dd32789 Sep 11, 2024
14 checks passed
@hansl hansl deleted the console-fixes branch September 11, 2024 16:30
hansl added a commit to hansl/boa that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants