Initial implementation of NaN-boxing

Co-authored-by: HalidOdat <[email protected]>
boa-dev · Sep 8, 2022 · f6bf8f4 · f6bf8f4
1 parent ba91449
commit f6bf8f4
Show file tree

Hide file tree

Showing 82 changed files with 2,391 additions and 1,110 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/boa_cli/src/main.rs b/boa_cli/src/main.rs
@@ -93,7 +93,7 @@ struct Opt {
     #[clap(long, short = 'a', value_name = "FORMAT", ignore_case = true, arg_enum)]
     dump_ast: Option<Option<DumpFormat>>,
 
-    /// Dump the AST to stdout with the given format.
+    /// Dump the compiled bytecode and trace the execution stack
     #[clap(long = "trace", short = 't')]
     trace: bool,
 

diff --git a/boa_engine/Cargo.toml b/boa_engine/Cargo.toml
@@ -23,6 +23,7 @@ intl = [
     "dep:icu_testdata",
     "dep:sys-locale"
 ]
+nan_boxing = ["dep:sptr", "dep:num_enum"]
 
 # Enable Boa's WHATWG console object implementation.
 console = []
@@ -50,6 +51,9 @@ unicode-normalization = "0.1.21"
 dyn-clone = "1.0.9"
 once_cell = "1.14.0"
 tap = "1.0.1"
+cfg-if = "1.0.0"
+sptr = { version = "0.3.1", optional = true }
+num_enum = { version = "0.5.7", optional = true }
 icu_locale_canonicalizer = { version = "0.6.0", features = ["serde"], optional = true }
 icu_locid = { version = "0.6.0", features = ["serde"], optional = true }
 icu_datetime = { version = "0.6.0", features = ["serde"], optional = true }

diff --git a/boa_engine/src/bigint.rs b/boa_engine/src/bigint.rs
@@ -1,10 +1,11 @@
 //! This module implements the JavaScript bigint primitive rust type.
 
-use crate::{builtins::Number, Context, JsValue};
+use crate::{builtins::Number, value::PointerType, Context, JsValue};
 use num_integer::Integer;
 use num_traits::{pow::Pow, FromPrimitive, One, ToPrimitive, Zero};
 use std::{
     fmt::{self, Display},
+    mem::{self, ManuallyDrop},
     ops::{Add, BitAnd, BitOr, BitXor, Div, Mul, Neg, Rem, Shl, Shr, Sub},
     rc::Rc,
 };
@@ -22,6 +23,16 @@ pub struct JsBigInt {
     inner: Rc<RawBigInt>,
 }
 
+unsafe impl PointerType for JsBigInt {
+    unsafe fn from_void_ptr(ptr: *mut ()) -> ManuallyDrop<Self> {
+        ManuallyDrop::new(mem::transmute(ptr))
+    }
+
+    unsafe fn into_void_ptr(bigint: ManuallyDrop<Self>) -> *mut () {
+        mem::transmute(bigint)
+    }
+}
+
 impl JsBigInt {
     /// Create a new [`JsBigInt`].
     #[inline]

diff --git a/boa_engine/src/builtins/array/array_iterator.rs b/boa_engine/src/builtins/array/array_iterator.rs
@@ -68,7 +68,8 @@ impl ArrayIterator {
     ///
     /// [spec]: https://tc39.es/ecma262/#sec-%arrayiteratorprototype%.next
     pub(crate) fn next(this: &JsValue, _: &[JsValue], context: &mut Context) -> JsResult<JsValue> {
-        let mut array_iterator = this.as_object().map(JsObject::borrow_mut);
+        let array_iterator = this.as_object();
+        let mut array_iterator = array_iterator.as_deref().map(JsObject::borrow_mut);
         let array_iterator = array_iterator
             .as_mut()
             .and_then(|obj| obj.as_array_iterator_mut())