Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add changelog doc and testnet Fermat height #75

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

owen-reorg
Copy link
Collaborator

@owen-reorg owen-reorg commented Oct 20, 2023

Description

Add changelog doc and testnet Fermat height.

Rationale

NA

Example

NA

Changes

NA

welkin22
welkin22 previously approved these changes Oct 20, 2023
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

redhdx
redhdx previously approved these changes Oct 20, 2023
2129zxl

This comment was marked as abuse.

krish-nr
krish-nr previously approved these changes Oct 20, 2023
Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the content related to P2P Engine sync

@owen-reorg owen-reorg dismissed stale reviews from krish-nr, redhdx, and welkin22 via 7cfe1c3 October 26, 2023 04:12
@owen-reorg owen-reorg marked this pull request as ready for review October 26, 2023 04:19
@owen-reorg owen-reorg changed the title docs: add changelog doc chore: add changelog doc and testnet Fermat height Oct 26, 2023
bendanzhentan
bendanzhentan previously approved these changes Oct 26, 2023
welkin22
welkin22 previously approved these changes Oct 26, 2023
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@owen-reorg owen-reorg merged commit 2fcb540 into bnb-chain:develop Oct 26, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants