Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-node): alchemy as rpc node for opbnb #229

Closed
wants to merge 3 commits into from

Conversation

Eoous
Copy link

@Eoous Eoous commented Aug 6, 2024

Description

Fix: #228

Changes

When using alchemy as L1_RPC_KIND:

  • fallback to `EthGetTransactionReceiptBatch
  • check error message

@github-actions github-actions bot requested review from bnoieh and redhdx August 6, 2024 03:11
bnoieh
bnoieh previously approved these changes Aug 21, 2024
@welkin22
Copy link
Contributor

welkin22 commented Aug 21, 2024

@Eoous Hi, please fix the broken unit tests first.

@Eoous
Copy link
Author

Eoous commented Aug 21, 2024

@welkin22 How about deleting the test cases for alchemy? Currently alchemy only support standard methods and no need to do fallback test

In addition there're some timers for response required delay, they would print warn or error if use third-party service

@welkin22
Copy link
Contributor

@welkin22 How about deleting the test cases for alchemy? Currently alchemy only support standard methods and no need to do fallback test

In addition there're some timers for response required delay, they would print warn or error if use third-party service

Yes, these test cases are no longer needed.

Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg
Copy link
Collaborator

We'll put this pull request on hold as we're communicating with Alchemy to add support for the missing APIs in their BSC endpoint.

@Eoous
Copy link
Author

Eoous commented Aug 30, 2024

We'll put this pull request on hold as we're communicating with Alchemy to add support for the missing APIs in their BSC endpoint.

That's great

@Eoous Eoous closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't use alchemy as l1 rpc
4 participants