Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(op-node): continue optimizing sequencer step schedule #101

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Dec 19, 2023

Description

continue optimizing sequencer step schedule

Rationale

there're still some corner cases, in which sequencer block produce may has issue:

  1. if whole l1 network went down for more than maxSequencerDrift time, sequencer was unable to auto-recover after l1 network recovered
  2. when high l1 network latency last for a long time(> maxSequencerDrift), sequencer will produce block but difficult to produce full block
  3. when sequencer step is hot(e.g. catching up), admin_stopSequencer operation may failed due to context timeout

this PR will fix above cases.

Example

n/a

Changes

  1. call sequencerStep() immediately rather than reset sequencerTimer
  2. handle l1HeadSig before call sequencerStep() to avoid error caused by cannot find next l1 block
  3. add accEmptyBlocks in sequencer.go to avoid never produce full block in corner case
  4. add more steps to high priority schedule

@owen-reorg owen-reorg merged commit 5f592b5 into bnb-chain:develop Jan 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants