Fix: src: device: manager: Panic when call unimplemented options #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/device/manager.rs
Outdated
| .respond_to | ||
| .send(Err(ManagerError::NotImplemented(actor_request.request))) | ||
| { | ||
| warn!("DeviceManager: Failed to return response: {:?}", e); |
There was a problem hiding this comment.
We often prefer to use it like {e:?}, but I don't know if this repo is following this idea
There was a problem hiding this comment.
some habits are difficult to break, I learned this way when was learning C haha
I'm going to apply and keep this stantandard then.
There was a problem hiding this comment.
there's some special cases that seems it doesn't work:
warn!(
"Unsupported request for device type: {:?}",
&self.device_type
);
There was a problem hiding this comment.
ping @joaoantoniocardoso
Please check the newer commit below!
joaoantoniocardoso
approved these changes
Jul 19, 2024
…p variables inside log description, following our current standards
joaoantoniocardoso
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.