Update: Requests pattern #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaulTrombin
force-pushed
the
update_request_pattern
branch
6 times, most recently
from
c9b1c19
to
6a9aa25
Compare
RaulTrombin
force-pushed
the
update_request_pattern
branch
from
6a9aa25
to
52c24b6
Compare
src/device/manager/mod.rs
Outdated
Comment on lines
162
to
173
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub struct UuidWrapper { | ||
| pub uuid: Uuid, | ||
| } | ||
|
|
||
| impl UuidWrapper { | ||
| pub fn uuid(&self) -> Uuid { | ||
| self.uuid | ||
| } | ||
| } | ||
|
|
||
| impl From<Uuid> for UuidWrapper { | ||
| fn from(uuid: Uuid) -> Self { | ||
| UuidWrapper { uuid } | ||
| } | ||
| } | ||
|
|
||
| impl From<UuidWrapper> for Uuid { | ||
| fn from(wrapper: UuidWrapper) -> Self { | ||
| wrapper.uuid | ||
| } |
There was a problem hiding this comment.
You can instead, implement deref trait:
impl Deref for UuidWrapper {
type Target = Uuid;
fn deref(&self) -> &Self::Target {
&self.uuid
}
}then use *uuid instead of uuid.into()
RaulTrombin
force-pushed
the
update_request_pattern
branch
from
52c24b6
to
e2f8889
Compare
joaoantoniocardoso
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs:
Details: